With PMD 5.1.3, no warning is given when analysing this piece of code:
~~~~~~~~~
public class Bar {
public void foo() {
Connection c = pool.getConnection();
try {
// do stuff
} catch (SQLException ex) {
// handle exception
} finally {
if(false) {
c.close();
}
}
}
}
~~~~~~~~~~
The rule does not seem to take the "if" into account inside a finally block, and considers that c.close will be executed even if the code is dead. Whichever condition is set in the conditionnal (false, true, a variable, etc), PMD won't send a warning.
Log in to post a comment.